Nicholas Piggin <npiggin@xxxxxxxxx> writes: > Excerpts from Haren Myneni's message of April 18, 2021 7:02 am: >> >> Using the same /dev/crypto/nx-gzip interface for both powerNV and >> pseries. > > The pseries NX driver will use the powernv VAS API ? > >> So this patch creates platforms/book3s/ and moves VAS API >> to that directory. The actual functionality is not changed. >> >> Common interface functions such as open, window open ioctl, mmap >> and close are moved to arch/powerpc/platforms/book3s/vas-api.c >> Added hooks to call platform specific code, but the underline >> powerNV code in these functions is not changed. > > Even so, could you do one patch that just moves, and another that > adds the ops struct? > >> >> Signed-off-by: Haren Myneni <haren@xxxxxxxxxxxxx> >> --- >> arch/powerpc/include/asm/vas.h | 22 ++++++- >> arch/powerpc/platforms/Kconfig | 1 + >> arch/powerpc/platforms/Makefile | 1 + >> arch/powerpc/platforms/book3s/Kconfig | 15 +++++ >> arch/powerpc/platforms/book3s/Makefile | 2 + > > The usual place for these would be arch/powerpc/sysdev/vas. E.g., see > arch/powerpc/sysdev/xive. You're right that is the usual place, but is it a good place? :) Using platforms/book3s was my suggestion: https://lore.kernel.org/linuxppc-dev/87k0p6s5lo.fsf@xxxxxxxxxxxxxxxxxx/ But I don't feel that strongly about it, maybe just dumping things in sysdev is easier. cheers
