> -----Original Message----- > From: Fabio Estevam <festevam@xxxxxxxxx> > Sent: 2021年4月29日 22:05 > Subject: Re: [PATCH v1 2/2] caam: imx8m: change to use of_match_node in > run_descriptor_deco0 > > Hi Alice > > On Thu, Apr 29, 2021 at 11:02 AM Alice Guo (OSS) <alice.guo@xxxxxxxxxxx> > wrote: > > > > From: Alice Guo <alice.guo@xxxxxxx> > > > > Patch "fix the built-in caam driver cannot match soc_id" provides > > imx8m_machine_match to match i.MX8M{Q,M,N,P}, so change to use to > > of_match_node which can simplify the code. > > Shouldn't these patches be squashed? These patches should not be squashed because "fix the built-in caam driver cannot match soc_id" is mainly used to provide defer probe when soc device has not been probed yet, and is only for i.MX8M. "change to use of_match_node in run_descriptor_deco0" is just to simplify code. Best Regards, Alice Guo