> On Apr 27, 2021, at 3:09 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote: > > On 4/26/21 4:46 PM, Nick Terrell wrote: >> From: Nick Terrell <terrelln@xxxxxx> >> >> Please pull from >> >> git@xxxxxxxxxx:terrelln/linux.git tags/v10-zstd-1.4.10 >> >> to get these changes. Alternatively the patchset is included. >> >> This patchset lists me as the maintainer for zstd and upgrades the zstd library >> to the latest upstream release. The current zstd version in the kernel is a >> modified version of upstream zstd-1.3.1. At the time it was integrated, zstd >> wasn't ready to be used in the kernel as-is. But, it is now possible to use >> upstream zstd directly in the kernel. > > Hi Nick, > > Several of the source (.c, .h) files use comments blocks that > begin with "/**", which means "this is the beginning of a kernel-doc > comment" when in the kernel source tree. However, they are not in > kernel-doc format. > > During the automatic generation from upstream zstd, please find a way > to change /** to /*. > > This does need to slow down the acceptance of this patch series IMO. Sure, I can do that easily enough. The public header `include/linux/zstd.h` already does have correct kernel-doc comments. It is just the non-public files that don’t follow the kernel-doc style, since zstd has its own documentation format which is similar to doxygen style. Best, Nick > thanks. > -- > ~Randy >
