Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
From: Borislav Petkov <bp@xxxxxxx>
Date: Wed, 7 Apr 2021 19:34:07 +0200
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Brijesh Singh <brijesh.singh@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, John Allen <john.allen@xxxxxxx>, Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>, Wanpeng Li <wanpengli@xxxxxxxxxxx>, Jim Mattson <jmattson@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, kvm@xxxxxxxxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <YG3mQ+U6ZnoWIZ9a@google.com>
References: <20210406224952.4177376-1-seanjc@google.com> <20210406224952.4177376-9-seanjc@google.com> <9df3b755-d71a-bfdf-8bee-f2cd2883ea2f@csgroup.eu> <20210407102440.GA25732@zn.tnic> <YG3mQ+U6ZnoWIZ9a@google.com>

On Wed, Apr 07, 2021 at 05:05:07PM +0000, Sean Christopherson wrote:
> I used memset() to defer initialization until after the various sanity
> checks,

I'd actually vote for that too - I don't like doing stuff which is not
going to be used. I.e., don't change what you have.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

Follow-Ups:
- Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
  - From: Paolo Bonzini

References:
- [PATCH v2 0/8] ccp: KVM: SVM: Use stack for SEV command buffers
  - From: Sean Christopherson
- [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
  - From: Sean Christopherson
- Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
  - From: Christophe Leroy
- Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
  - From: Borislav Petkov
- Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
  - From: Sean Christopherson

Prev by Date: Re: [PATCH v7 0/5] Enable root to update the blacklist keyring
Next by Date: Re: [PATCH v2 0/8] ccp: KVM: SVM: Use stack for SEV command buffers
Previous by thread: Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
Next by thread: Re: [PATCH v2 8/8] KVM: SVM: Allocate SEV command structures on local stack
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]