On Tue, Mar 09, 2021 at 01:50:03AM +0530, Vaibhav Gupta wrote: > From: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > > Add the AM64 version of sa2ul to the compatible list. > > [v_gupta@xxxxxx: Conditional dma-coherent requirement, clocks] > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx> > Signed-off-by: Vaibhav Gupta <v_gupta@xxxxxx> > --- > .../devicetree/bindings/crypto/ti,sa2ul.yaml | 40 +++++++++++++++---- > 1 file changed, 33 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > index 1d48ac712b23..6eb9acd564c2 100644 > --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml > @@ -14,6 +14,7 @@ properties: > enum: > - ti,j721e-sa2ul > - ti,am654-sa2ul > + - ti,am64-sa2ul > > reg: > maxItems: 1 > @@ -45,19 +46,44 @@ properties: > description: > Address translation for the possible RNG child node for SA2UL > > + clocks: > + items: > + - description: Clock used by PKA > + - description: Main Input Clock > + - description: Clock used by rng > + > + clock-names: > + items: > + - const: pka_in_clk > + - const: x1_clk > + - const: x2_clk > + > patternProperties: > "^rng@[a-f0-9]+$": > type: object > description: > Child RNG node for SA2UL > > -required: > - - compatible > - - reg > - - power-domains > - - dmas > - - dma-names > - - dma-coherent > +if: > + properties: > + compatible: > + const: ti,am64-sa2ul > +then: > + required: > + - compatible > + - reg > + - power-domains > + - dmas > + - dma-names > + > +else: > + required: > + - compatible > + - reg > + - power-domains > + - dmas > + - dma-names > + - dma-coherent The only difference is 'dma-coherent'. You can simplify the if/then to just that.
