On 2021/3/12 20:59, Herbert Xu wrote: > On Thu, Mar 04, 2021 at 02:18:54PM +0800, Longfang Liu wrote: >> >> @@ -727,7 +725,7 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req, >> struct aead_request *aead_req = req->aead_req.aead_req; >> struct sec_cipher_req *c_req = &req->c_req; >> struct sec_qp_ctx *qp_ctx = req->qp_ctx; >> - struct device *dev = SEC_CTX_DEV(ctx); >> + struct device *dev = ctx->dev; >> int copy_size, pbuf_length; >> int req_id = req->req_id; >> >> @@ -737,11 +735,9 @@ static void sec_cipher_pbuf_unmap(struct sec_ctx *ctx, struct sec_req *req, >> copy_size = c_req->c_len; >> >> pbuf_length = sg_copy_from_buffer(dst, sg_nents(dst), >> - qp_ctx->res[req_id].pbuf, >> - copy_size); >> - >> + qp_ctx->res[req_id].pbuf, copy_size); >> if (unlikely(pbuf_length != copy_size)) >> - dev_err(dev, "copy pbuf data to dst error!\n"); >> + dev_err(ctx->dev, "copy pbuf data to dst error!\n"); >> } > > This triggers an unused warning on dev. Please fix. > > Thanks, > Ok! I will check if this problem exists elsewhere. Thanks, Longfang
