On Fri, Mar 12, 2021 at 5:48 PM Tong Zhang <ztong0001@xxxxxxxxx> wrote: Please, do not top post when replying to the email. > Complete newbie here, could you please remind me of the tag you are > referring to? Reviewed-by IIRC. > I am not really familiar with the process. Have you read [1]? The chapters 11-13 refer to the tags. > On Fri, Mar 12, 2021 at 10:35 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Fri, Mar 12, 2021 at 4:21 PM Tong Zhang <ztong0001@xxxxxxxxx> wrote: > > > > > > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown() > > > before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the > > > vf2pf_lock is initialized in adf_dev_init(), which can fail and when it > > > fail, the vf2pf_lock is either not initialized or destroyed, a subsequent > > > use of vf2pf_lock will cause issue. > > > To fix this issue, only set this flag if adf_dev_init() returns 0. > > > > > > [ 7.178404] BUG: KASAN: user-memory-access in __mutex_lock.isra.0+0x1ac/0x7c0 > > > [ 7.180345] Call Trace: > > > [ 7.182576] mutex_lock+0xc9/0xd0 > > > [ 7.183257] adf_iov_putmsg+0x118/0x1a0 [intel_qat] > > > [ 7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat] > > > [ 7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat] > > > [ 7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf] > > > > Don't you miss the tag I gave? [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html -- With Best Regards, Andy Shevchenko
