On Thu, Feb 18, 2021 at 10:01:58AM +0800, liulongfang wrote: > > >> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c > >> index d2c4a2c..988faf7 100644 > >> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c > >> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c > >> @@ -7,6 +7,7 @@ > >> #include <crypto/des.h> > >> #include <crypto/hash.h> > >> #include <crypto/internal/aead.h> > >> +#include <crypto/internal/hash.h> > > > > Please explain what exactly in this file needs this header file. > > > > As it stands you could just be hiding real bugs. > > > > Thanks, > > > The crypto_alloc_shash() interface in the header file > will be used in the function sec_aead_ctx_init(), > If this header file is not added, calling the interface > crypto_alloc_shash() during the initialization of the > aead algorithm will return an error. This makes no sense whatsoever as crypto_alloc_shash is defiend by crypto/hash.h and you've already included that. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
