Re: [PATCH v8 5/9] crypto: move curve_id of ECDH to algorithm name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Meng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master v5.11-rc6 next-20210125]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Meng-Yu/add-ECDH-and-CURVE25519-algorithms-support-for-Kunpeng-930/20210209-073324
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: powerpc64-randconfig-r015-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/eeb0603ffdb2894db839c813cc66c4c08920d61b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Meng-Yu/add-ECDH-and-CURVE25519-algorithms-support-for-Kunpeng-930/20210209-073324
        git checkout eeb0603ffdb2894db839c813cc66c4c08920d61b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from crypto/testmgr.c:73:
>> crypto/testmgr.h:2304:2: error: expected '}'
   };
    ^
   crypto/testmgr.h:2264:59: note: to match this '{'
   static const struct kpp_testvec ecdh_p192_tv_template[] = {
                                                             ^
>> crypto/testmgr.c:4917:11: error: invalid application of 'sizeof' to an incomplete type 'const struct kpp_testvec []'
                           .kpp = __VECS(ecdh_p192_tv_template)
                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   crypto/testmgr.c:4149:22: note: expanded from macro '__VECS'
   #define __VECS(tv)      { ____VECS(tv) }
                             ^~~~~~~~~~~~
   crypto/testmgr.c:4148:43: note: expanded from macro '____VECS'
   #define ____VECS(tv)    .vecs = tv, .count = ARRAY_SIZE(tv)
                                                ^~~~~~~~~~~~~~
   include/linux/kernel.h:49:32: note: expanded from macro 'ARRAY_SIZE'
   #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                  ^~~~~
>> crypto/testmgr.c:5515:18: error: invalid application of 'sizeof' to an incomplete type 'const struct alg_test_desc []'
           for (i = 1; i < ARRAY_SIZE(alg_test_descs); i++) {
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/kernel.h:49:32: note: expanded from macro 'ARRAY_SIZE'
   #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                  ^~~~~
   crypto/testmgr.c:5558:12: error: invalid application of 'sizeof' to an incomplete type 'const struct alg_test_desc []'
           int end = ARRAY_SIZE(alg_test_descs);
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/kernel.h:49:32: note: expanded from macro 'ARRAY_SIZE'
   #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
                                  ^~~~~
   4 errors generated.


vim +2304 crypto/testmgr.h

  2263	
  2264	static const struct kpp_testvec ecdh_p192_tv_template[] = {
  2265		{
  2266	#ifndef CONFIG_CRYPTO_FIPS
  2267		.secret =
  2268	#ifdef __LITTLE_ENDIAN
  2269		"\x02\x00" /* type */
  2270		"\x1e\x00" /* len */
  2271		"\x18\x00" /* key_size */
  2272	#else
  2273		"\x00\x02" /* type */
  2274		"\x00\x1e" /* len */
  2275		"\x00\x18" /* key_size */
  2276	#endif
  2277		"\xb5\x05\xb1\x71\x1e\xbf\x8c\xda"
  2278		"\x4e\x19\x1e\x62\x1f\x23\x23\x31"
  2279		"\x36\x1e\xd3\x84\x2f\xcc\x21\x72",
  2280		.b_public =
  2281		"\xc3\xba\x67\x4b\x71\xec\xd0\x76"
  2282		"\x7a\x99\x75\x64\x36\x13\x9a\x94"
  2283		"\x5d\x8b\xdc\x60\x90\x91\xfd\x3f"
  2284		"\xb0\x1f\x8a\x0a\x68\xc6\x88\x6e"
  2285		"\x83\x87\xdd\x67\x09\xf8\x8d\x96"
  2286		"\x07\xd6\xbd\x1c\xe6\x8d\x9d\x67",
  2287		.expected_a_public =
  2288		"\x1a\x04\xdb\xa5\xe1\xdd\x4e\x79"
  2289		"\xa3\xe6\xef\x0e\x5c\x80\x49\x85"
  2290		"\xfa\x78\xb4\xef\x49\xbd\x4c\x7c"
  2291		"\x22\x90\x21\x02\xf9\x1b\x81\x5d"
  2292		"\x0c\x8a\xa8\x98\xd6\x27\x69\x88"
  2293		"\x5e\xbc\x94\xd8\x15\x9e\x21\xce",
  2294		.expected_ss =
  2295		"\xf4\x57\xcc\x4f\x1f\x4e\x31\xcc"
  2296		"\xe3\x40\x60\xc8\x06\x93\xc6\x2e"
  2297		"\x99\x80\x81\x28\xaf\xc5\x51\x74",
  2298		.secret_size = 32,
  2299		.b_public_size = 48,
  2300		.expected_a_public_size = 48,
  2301		.expected_ss_size = 24
  2302		}
  2303	#endif
> 2304	};
  2305	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux