On 2021/2/7 16:02, Ard Biesheuvel wrote: > On Sun, 7 Feb 2021 at 03:47, liulongfang <liulongfang@xxxxxxxxxx> wrote: >> >> On 2021/2/5 19:44, Herbert Xu write: >>> On Fri, Feb 05, 2021 at 06:10:57PM +0800, Longfang Liu wrote: >>>> If this configuration item is not turned on, >>>> the allocation of crypto_tfm will fail when >>>> the shash algorithm calculates the hash >>>> through the software. >>>> >>>> Signed-off-by: Longfang Liu <liulongfang@xxxxxxxxxx> >>>> --- >>>> arch/arm64/configs/defconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>>> index 8383016..7cfc9b6 100644 >>>> --- a/arch/arm64/configs/defconfig >>>> +++ b/arch/arm64/configs/defconfig >>>> @@ -117,7 +117,7 @@ CONFIG_KVM=y >>>> CONFIG_ARM64_CRYPTO=y >>>> CONFIG_CRYPTO_SHA1_ARM64_CE=y >>>> CONFIG_CRYPTO_SHA2_ARM64_CE=y >>>> -CONFIG_CRYPTO_SHA512_ARM64_CE=m >>>> +CONFIG_CRYPTO_SHA512_ARM64_CE=y >>> >>> If this is truly needed then it should be enabled through Kconfig. >>> >>> Cheers, >>> >> Hi Herbert, >> The option select CRYPTO_SHA512 already exists in Kconfig. > > In that case, how can the shash TFM allocation fail? > Hi After comparison and investigation, the problem is that the header file "crypto/internal/hash.h" is not added. After adding this header file, which CRYPTO_SHA512_ARM64_C compilation option does not need to be enabled. I will modify it in the next patch. >> Can I change it to this: select CRYPTO_SHA512 || CRYPTO_SHA512_ARM64_CE > > No, you cannot select expressions like that. > > Could you please explain the problem you are trying to solve? > . > When allocation shash TFM with hmac(sha512)-cbc(aes) algorithm, TFM will return an error. Thanks Longfang.
