On Wed, 3 Feb 2021 at 12:19, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Feb 03, 2021 at 10:37:10AM +0100, Ard Biesheuvel wrote: > > > > One thing that became apparent to me while looking into this stuff is > > that the skcipher encrypt/decrypt API ignores alignmasks altogether, > > so this is something we should probably look into at some point, i.e., > > whether the alignmask handling in the core API is still worth it, and > > if it is, make skcipher calls honour them. > > > > In the ablkcipher->skcipher conversion I did, I was not aware of this, > > but I don't remember seeing any issues being reported in this area > > either, so I wonder how many cases actually exist where alignmasks > > actually matter. > > What do you mean? With both ablkcipher/skcipher the alignmask was > usually enforced through the walker mechanism. > Oops, I missed that completely. Apologies for the noise.
