Re: [PATCH] crypto: marvel/cesa - Fix tdma descriptor on 64-bit

[Sven Auhagen <sven.auhagen@xxxxxxxxxxxx>]

On Wed, Jan 20, 2021 at 04:40:45PM +1100, Herbert Xu wrote:
> On Wed, Jan 20, 2021 at 04:26:29PM +1100, Herbert Xu wrote:
> >
> > Is your machine big-endian or little-endian?
> 
> Does this patch fix your problem?

Yes, it fixes the problem and also the failing hash test.

Thanks and best
Sven

> 
> ---8<---
> The patch that added src_dma/dst_dma to struct mv_cesa_tdma_desc
> is broken on 64-bit systems as the size of the descriptor has been
> changed.  This patch fixes it by using u32 instead of dma_addr_t.
> 
> Fixes: e62291c1d9f4 ("crypto: marvell/cesa - Fix sparse warnings")
> Reported-by: Sven Auhagen <sven.auhagen@xxxxxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> 
> diff --git a/drivers/crypto/marvell/cesa/cesa.h b/drivers/crypto/marvell/cesa/cesa.h
> index fabfaaccca87..fa56b45620c7 100644
> --- a/drivers/crypto/marvell/cesa/cesa.h
> +++ b/drivers/crypto/marvell/cesa/cesa.h
> @@ -300,11 +300,11 @@ struct mv_cesa_tdma_desc {
>  	__le32 byte_cnt;
>  	union {
>  		__le32 src;
> -		dma_addr_t src_dma;
> +		u32 src_dma;
>  	};
>  	union {
>  		__le32 dst;
> -		dma_addr_t dst_dma;
> +		u32 dst_dma;
>  	};
>  	__le32 next_dma;
>  
> -- 
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: https://eur03.safelinks.protection.outlook.com/?url=http:%2F%2Fgondor.apana.org.au%2F~herbert%2F&amp;data=04%7C01%7Csven.auhagen%40voleatech.de%7Ca0b247450d1b4580bc8408d8bd05f397%7Cb82a99f679814a7295344d35298f847b%7C0%7C0%7C637467180564502107%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=HN3G1xs2oayGqA7gCAuPe57Fshkjci1ObQIz7PouXC8%3D&amp;reserved=0
> PGP Key: https://eur03.safelinks.protection.outlook.com/?url=http:%2F%2Fgondor.apana.org.au%2F~herbert%2Fpubkey.txt&amp;data=04%7C01%7Csven.auhagen%40voleatech.de%7Ca0b247450d1b4580bc8408d8bd05f397%7Cb82a99f679814a7295344d35298f847b%7C0%7C0%7C637467180564512065%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=6VdTmXDuV4ed5p%2B8ATbjpn%2BObkSqBFyqjkRYPod8sC4%3D&amp;reserved=0