Re: [PATCH] crypto: lib/chacha20poly1305 - define empty module exit function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Jan 15, 2021, at 11:17 AM, Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> 
> With no mod_exit function, users are unable to load the module after
> use. I'm not aware of any reason why module unloading should be
> prohibited for this one, so this commit simply adds an empty exit
> function.
> 
> Reported-by: John Donnelly <john.p.donnelly@xxxxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> ---


Hi ,

 Verified 

 Please add 


  Test-by: John Donnelly <john.p.donnelly@xxxxxxxxxx>



> lib/crypto/chacha20poly1305.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
> index 5850f3b87359..c2fcdb98cc02 100644
> --- a/lib/crypto/chacha20poly1305.c
> +++ b/lib/crypto/chacha20poly1305.c
> @@ -362,7 +362,12 @@ static int __init mod_init(void)
> 	return 0;
> }
> 
> +static void __exit mod_exit(void)
> +{
> +}
> +
> module_init(mod_init);
> +module_exit(mod_exit);
> MODULE_LICENSE("GPL v2");
> MODULE_DESCRIPTION("ChaCha20Poly1305 AEAD construction");
> MODULE_AUTHOR("Jason A. Donenfeld <Jason@xxxxxxxxx>");
> -- 
> 2.30.0
> 




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux