On Wed, Dec 23, 2020 at 12:09:49AM -0800, Eric Biggers wrote: > This patchset adds 32-bit ARM assembly language implementations of > BLAKE2b and BLAKE2s. > > As a prerequisite to adding these without copy-and-pasting lots of code, > this patchset also reworks the existing BLAKE2b and BLAKE2s code to > provide helper functions that make implementing "shash" providers for > these algorithms much easier. These changes also eliminate unnecessary > differences between the BLAKE2b and BLAKE2s code. > > The new BLAKE2b implementation is NEON-accelerated, while the new > BLAKE2s implementation uses scalar instructions since NEON doesn't work > very well for it. The BLAKE2b implementation is faster and is expected > to be useful as a replacement for SHA-1 in dm-verity, while the BLAKE2s > implementation would be useful for WireGuard which uses BLAKE2s. > > Both new implementations are wired up to the shash API, while the new > BLAKE2s implementation is also wired up to the library API. > > See the individual commits for full details, including benchmarks. > > This patchset was tested on a Raspberry Pi 2 (which uses a Cortex-A7 > processor) with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y, plus other tests. > > This patchset applies to mainline commit 614cb5894306. > > Changed since v2: > - Reworked the shash helpers again. Now they are inline functions, > and for BLAKE2s they now share more code with the library API. > - Made the BLAKE2b code be more consistent with the BLAKE2s code. > - Moved the BLAKE2s changes first in the patchset so that the BLAKE2b > changes can be made just by syncing the code with BLAKE2s. > - Added a few BLAKE2s cleanups (which get included in BLAKE2b too). > - Improved some comments in the new asm files. > > Changed since v1: > - Added ARM scalar implementation of BLAKE2s. > - Adjusted the BLAKE2b helper functions to be consistent with what I > decided to do for BLAKE2s. > - Fixed build error in blake2b-neon-core.S in some configurations. > > Eric Biggers (14): > crypto: blake2s - define shash_alg structs using macros > crypto: x86/blake2s - define shash_alg structs using macros > crypto: blake2s - remove unneeded includes > crypto: blake2s - move update and final logic to internal/blake2s.h > crypto: blake2s - share the "shash" API boilerplate code > crypto: blake2s - optimize blake2s initialization > crypto: blake2s - add comment for blake2s_state fields > crypto: blake2s - adjust include guard naming > crypto: blake2s - include <linux/bug.h> instead of <asm/bug.h> > crypto: arm/blake2s - add ARM scalar optimized BLAKE2s > wireguard: Kconfig: select CRYPTO_BLAKE2S_ARM > crypto: blake2b - sync with blake2s implementation > crypto: blake2b - update file comment > crypto: arm/blake2b - add NEON-accelerated BLAKE2b > > arch/arm/crypto/Kconfig | 19 ++ > arch/arm/crypto/Makefile | 4 + > arch/arm/crypto/blake2b-neon-core.S | 347 ++++++++++++++++++++++++++++ > arch/arm/crypto/blake2b-neon-glue.c | 105 +++++++++ > arch/arm/crypto/blake2s-core.S | 285 +++++++++++++++++++++++ > arch/arm/crypto/blake2s-glue.c | 78 +++++++ > arch/x86/crypto/blake2s-glue.c | 150 +++--------- > crypto/blake2b_generic.c | 249 +++++--------------- > crypto/blake2s_generic.c | 158 +++---------- > drivers/net/Kconfig | 1 + > include/crypto/blake2b.h | 67 ++++++ > include/crypto/blake2s.h | 63 ++--- > include/crypto/internal/blake2b.h | 115 +++++++++ > include/crypto/internal/blake2s.h | 109 ++++++++- > lib/crypto/blake2s.c | 48 +--- > 15 files changed, 1278 insertions(+), 520 deletions(-) > create mode 100644 arch/arm/crypto/blake2b-neon-core.S > create mode 100644 arch/arm/crypto/blake2b-neon-glue.c > create mode 100644 arch/arm/crypto/blake2s-core.S > create mode 100644 arch/arm/crypto/blake2s-glue.c > create mode 100644 include/crypto/blake2b.h > create mode 100644 include/crypto/internal/blake2b.h All applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
