Re: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Fri, 18 Dec 2020 10:59:27 +0100
Cc: tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxx, luto@xxxxxxxxxx, x86@xxxxxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx, dan.j.williams@xxxxxxxxx, dave.hansen@xxxxxxxxx, ravi.v.shankar@xxxxxxxxx, ning.sun@xxxxxxxxx, kumar.n.dwarakanath@xxxxxxxxx, linux-crypto@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <20201216174146.10446-7-chang.seok.bae@intel.com>
References: <20201216174146.10446-1-chang.seok.bae@intel.com> <20201216174146.10446-7-chang.seok.bae@intel.com>

On Wed, Dec 16, 2020 at 09:41:44AM -0800, Chang S. Bae wrote:
> +	/* ENCODEKEY128 %EAX */
> +	asm volatile (".byte 0xf3, 0xf, 0x38, 0xfa, 0xc0");

This is lacking a binutils version number. Boris, didn't you do a
checkpatch.pl thing for that?

Follow-Ups:
- Re: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance
  - From: Bae, Chang Seok

References:
- [RFC PATCH 0/8] x86: Support Intel Key Locker
  - From: Chang S. Bae
- [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance
  - From: Chang S. Bae

Prev by Date: Re: [NEEDS-REVIEW] [RFC PATCH 7/8] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions
Next by Date: Re: [RFC PATCH 7/8] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions
Previous by thread: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance
Next by thread: Re: [RFC PATCH 6/8] selftests/x86: Test Key Locker internal key maintenance
Index(es):
- Date
- Thread

[Index of Archives] [Kernel] [Gnu Classpath] [Gnu Crypto] [DM Crypt] [Netfilter] [Bugtraq]

Powered by Linux