> On Dec 15, 2020, at 4:58 PM, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Dec 16, 2020 at 12:48:51AM +0000, Nick Terrell wrote: >> >> Thanks for the advice! The first zstd patches went through Herbert’s tree, which is >> why I’ve sent them this way. > > Sorry, but I'm not touch these patches as Christoph's objections > don't seem to have been addressed. I believe I’ve addressed Christoph's objections. He suggested creating a wrapper API to avoid changing callers upon the zstd update. I’ve done that, the only difference between the current API, and the changes I’ve proposed patch 1, is that I’ve changed the prefix from ZSTD_ to zstd_ to avoid conflicts & confusion with the upstream zstd API. Cristoph, if you get a chance to take a look at these patches, please let me know what you think about the current iteration of patches, and if I’ve addressed all of your concerns. Best, Nick
