On Tue, Dec 01, 2020 at 02:24:50PM +0000, Giovanni Cabiddu wrote: > > @@ -1293,6 +1366,12 @@ static int qat_alg_skcipher_init_xts_tfm(struct crypto_skcipher *tfm) > if (IS_ERR(ctx->ftfm)) > return PTR_ERR(ctx->ftfm); > > + ctx->tweak = crypto_alloc_cipher("aes", 0, 0); > + if (IS_ERR(ctx->tweak)) { > + crypto_free_skcipher(ctx->ftfm); > + return PTR_ERR(ctx->tweak); > + } > + > reqsize = max(sizeof(struct qat_crypto_request), > sizeof(struct skcipher_request) + > crypto_skcipher_reqsize(ctx->ftfm)); This may clash with the work that Ard is doing on simpler ciphers. So I think this should switch over to using the library interface for aes. What do you think Ard? Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt