On Tue, 1 Dec 2020 at 22:57, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Dec 01, 2020 at 08:45:56PM +0100, Ard Biesheuvel wrote: > > Add ccm(aes) implementation from linux-wireless mailing list (see > > http://permalink.gmane.org/gmane.linux.kernel.wireless.general/126679). > > > > This eliminates FPU context store/restore overhead existing in more > > general ccm_base(ctr(aes-aesni),aes-aesni) case in MAC calculation. > > > > Suggested-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> > > Co-developed-by: Steve deRosier <derosier@xxxxxxxxxxxxxx> > > Signed-off-by: Steve deRosier <derosier@xxxxxxxxxxxxxx> > > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> > > --- > > v2: avoid the SIMD helper, as it produces an CRYPTO_ALG_ASYNC aead, which > > is not usable by the 802.11 ccmp driver > > Sorry, but this is not the way to go. Please fix wireless to > use the async interface instead. > This is not the first time this has come up. The point is that CCMP in the wireless stack is not used in 99% of the cases, given that any wifi hardware built in the last ~10 years can do it in hardware. Only in exceptional cases, such as Ben's, is there a need for exercising this interface. Also, care to explain why we have synchronous AEADs in the first place if they are not supposed to be used?
