Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Nov 2020 14:16:01 +1100 Herbert Xu wrote:
> On Wed, Nov 11, 2020 at 04:10:39PM -0800, Jakub Kicinski wrote:
> > On Mon, 9 Nov 2020 17:39:24 +0530 Srujana Challa wrote:  
> > > CPT offload module utilises the linux crypto framework to offload
> > > crypto processing. This patch registers supported algorithms by
> > > calling registration functions provided by the kernel crypto API.
> > > 
> > > The module currently supports:
> > > - AES block cipher in CBC,ECB,XTS and CFB mode.
> > > - 3DES block cipher in CBC and ECB mode.
> > > - AEAD algorithms.
> > >   authenc(hmac(sha1),cbc(aes)),
> > >   authenc(hmac(sha256),cbc(aes)),
> > >   authenc(hmac(sha384),cbc(aes)),
> > >   authenc(hmac(sha512),cbc(aes)),
> > >   authenc(hmac(sha1),ecb(cipher_null)),
> > >   authenc(hmac(sha256),ecb(cipher_null)),
> > >   authenc(hmac(sha384),ecb(cipher_null)),
> > >   authenc(hmac(sha512),ecb(cipher_null)),
> > >   rfc4106(gcm(aes)).  
> > 
> > Herbert, could someone who knows about crypto take a look at this, 
> > if the intention is to merge this via net-next?  
> 
> This patch seems to be quite large but it is self-contained.  How
> about waiting a release cycle and then resubmitting it to linux-crypto
> on its own?

SGTM, actually everything starting from patch 4 is in drivers/crypto, 
so we can merge the first 3 into net-next and the rest via crypto?



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux