On 6 Nov 2020, at 13:38, Christoph Hellwig wrote:
You just keep resedning this crap, don't you? Haven't you been told multiple times to provide a proper kernel API by now?
You do consistently ask for a shim layer, but you haven’t explained what we gain by diverging from the documented and tested API of the upstream zstd project. It’s an important discussion given that we hope to regularly update the kernel side as they make improvements in zstd.
The only benefit described so far seems to be camelcase related, but if there are problems in the API beyond that, I haven’t seen you describe them. I don’t think the camelcase alone justifies the added costs of the shim.
-chris
