On Wed, Oct 28, 2020 at 5:52 PM Srujana Challa <schalla@xxxxxxxxxxx> wrote: > > Attach LFs to CPT VF to process the crypto requests and register > LF interrupts. > > Signed-off-by: Suheil Chandran <schandran@xxxxxxxxxxx> > Signed-off-by: Srujana Challa <schalla@xxxxxxxxxxx> > --- > drivers/crypto/marvell/octeontx2/Makefile | 2 +- > .../marvell/octeontx2/otx2_cpt_common.h | 3 + > .../marvell/octeontx2/otx2_cpt_reqmgr.h | 145 +++++ > drivers/crypto/marvell/octeontx2/otx2_cptlf.h | 7 + > .../marvell/octeontx2/otx2_cptvf_main.c | 196 +++++++ > .../marvell/octeontx2/otx2_cptvf_mbox.c | 26 + > .../marvell/octeontx2/otx2_cptvf_reqmgr.c | 532 ++++++++++++++++++ > 7 files changed, 910 insertions(+), 1 deletion(-) > create mode 100644 drivers/crypto/marvell/octeontx2/otx2_cptvf_reqmgr.c > +static int init_tasklet_work(struct otx2_cptlfs_info *lfs) > +{ > + struct otx2_cptlf_wqe *wqe; > + int i, ret = 0; > + > + for (i = 0; i < lfs->lfs_num; i++) { > + wqe = kzalloc(sizeof(struct otx2_cptlf_wqe), GFP_KERNEL); > + if (!wqe) { > + ret = -ENOMEM; > + goto cleanup_tasklet; > + } > + > + tasklet_init(&wqe->work, cptlf_work_handler, (u64) wqe); > + wqe->lfs = lfs; > + wqe->lf_num = i; > + lfs->lf[i].wqe = wqe; > + } > + return 0; > +cleanup_tasklet: nit: here and elsewhere, please leave an empty line between the return statement and subsequent label.