Re: [PATCH] crypto: talitos - Fix sparse warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 02, 2020 at 02:40:00PM +0200, Christophe Leroy wrote:
>
> However I guess the initial intention was to avoid conversion as much as
> possible. Most tests and bit wise operations can be done regardless of the
> endianess, that's the reason why the endianness conversion was applied to
> constants, in order to apply them at build time and avoid converting vars
> back and forth during runtime.
> 
> I have not looked at your patch in details but I have the feeling you are
> defeating this initial purpose.

I don't think that's a valid optimisation unless it's backed up
with real numbers.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux