Re: [PATCH v3,net-next,3/4] drivers: crypto: add support for OCTEONTX2 CPT engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2020-09-17 at 18:58 +0530, Srujana Challa wrote:
> Add support for the cryptographic acceleration unit (CPT) on
> 
> OcteonTX2 CN96XX SoC.
> 
> 
> 
> Signed-off-by: Suheil Chandran <schandran@xxxxxxxxxxx>
> 
> Signed-off-by: Lukas Bartosik <lbartosik@xxxxxxxxxxx>
> 
> Signed-off-by: Srujana Challa <schalla@xxxxxxxxxxx>
> 
> ---

[...]
>  15 files changed, 5088 insertions(+)

Huge patch, i suggest to break the whole series up to smaller patches, 
i suggest each component in a separate patch (e.g: infrastructure, new
mbox, debugfs, etc..)

What linux interfaces are going to enable your ipsec features? i
couldn't find any netdev, xfrm references in your series .. and the
cover letter + commit messages lack of such information.

FYI checkpatch is not happy at all with this patch:
total: 0 errors, 2 warnings, 85 checks, 5094 lines checked

85 mostly legit checks fire up.






[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux