On Fri, Sep 11, 2020 at 09:36:19AM +0800, Xiaoliang Pang wrote: > > diff --git a/drivers/crypto/mediatek/mtk-platform.c b/drivers/crypto/mediatek/mtk-platform.c > index 7e3ad085b5bd..ebb3bdef0dbe 100644 > --- a/drivers/crypto/mediatek/mtk-platform.c > +++ b/drivers/crypto/mediatek/mtk-platform.c > @@ -469,13 +469,13 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) > return 0; > > err_cleanup: > - for (; i--; ) { > + do { > dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, > ring[i]->res_base, ring[i]->res_dma); > dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ, > ring[i]->cmd_base, ring[i]->cmd_dma); > kfree(ring[i]); > - } > + }while(i--); Please add spaces before and after while. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt