On Fri, Sep 04, 2020 at 04:36:29PM +0000, Sunil Kovvuri Goutham wrote: > > > > -----Original Message----- > > From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Sent: Friday, September 4, 2020 7:48 PM > > To: Srujana Challa <schalla@xxxxxxxxxxx> > > Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > > crypto@xxxxxxxxxxxxxxx; Suheil Chandran <schandran@xxxxxxxxxxx>; > > Narayana Prasad Raju Athreya <pathreya@xxxxxxxxxxx>; Sunil Kovvuri > > Goutham <sgoutham@xxxxxxxxxxx>; Linu Cherian <lcherian@xxxxxxxxxxx>; > > Geethasowjanya Akula <gakula@xxxxxxxxxxx>; Jerin Jacob Kollanukkaran > > <jerinj@xxxxxxxxxxx>; Ard Biesheuvel <ardb@xxxxxxxxxx> > > Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for > > OCTEONTX2 CPT engine > > > > On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote: > > > > > > Since LMT store is our platform specific, it cannot be generalized to all > > ARM64. > > > > I'm not asking you to generalise it to all of ARM64. I'm asking you to move > > this into a header file under arch/arm64 that can then be shared by both your > > crypto driver and your network driver so you don't duplicate this > > everywhere. > > > > For ARM64 , except erratas other platform or machine dependent stuff are not allowed inside arch/arm64. > Also an earlier attempt by us to add few APIs addressing 128bit operations were not allowed by ARM folks > as they don't work in a generic way and are SOC specific. > http://lkml.iu.edu/hypermail/linux/kernel/1801.3/02211.html Maybe put it in include/linux/soc/ ? Andrew
