On 9/3/20 8:04 PM, Krzysztof Kozlowski wrote:
> Pass the error directly from devm_clk_get() to describe the real reason,
> instead of fixed ENOENT. Do not print error messages on deferred probe.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> drivers/crypto/s5p-sss.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f67f1e22ecd1..e83145c43b18 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -2201,11 +2201,10 @@ static int s5p_aes_probe(struct platform_device *pdev)
> }
>
> pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
> - if (IS_ERR(pdata->clk)) {
> - dev_err(dev, "failed to find secss clock %s\n",
> - variant->clk_names[0]);
> - return -ENOENT;
> - }
> + if (IS_ERR(pdata->clk))
> + return dev_err_probe(dev, PTR_ERR(pdata->clk),
> + "failed to find secss clock %s\n",
> + variant->clk_names[0]);
>
> err = clk_prepare_enable(pdata->clk);
> if (err < 0) {
> @@ -2217,9 +2216,9 @@ static int s5p_aes_probe(struct platform_device *pdev)
> if (variant->clk_names[1]) {
> pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
> if (IS_ERR(pdata->pclk)) {
> - dev_err(dev, "failed to find clock %s\n",
> - variant->clk_names[1]);
> - err = -ENOENT;
> + err = dev_err_probe(dev, PTR_ERR(pdata->pclk),
> + "failed to find clock %s\n",
> + variant->clk_names[1]);
> goto err_clk;
> }
>
>
Reviewed-by: Kamil Konieczny <k.konieczny@xxxxxxxxxxx>
Acked-by: Kamil Konieczny <k.konieczny@xxxxxxxxxxx>
