Re: [PATCH] crypto: arm64/sha - Add declarations for assembly variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 25 Aug 2020 at 03:41, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
>
> This patch adds declarations for variables only used by assembly
> code to silence compiler warnings:
>
>   CC [M]  arch/arm64/crypto/sha1-ce-glue.o
>   AS [M]  arch/arm64/crypto/sha1-ce-core.o
>   CC [M]  arch/arm64/crypto/sha2-ce-glue.o
>   AS [M]  arch/arm64/crypto/sha2-ce-core.o
>   CHECK   ../arch/arm64/crypto/sha1-ce-glue.c
>   CHECK   ../arch/arm64/crypto/sha2-ce-glue.c
> ../arch/arm64/crypto/sha1-ce-glue.c:38:11: warning: symbol 'sha1_ce_offsetof_count' was not declared. Should it be static?
> ../arch/arm64/crypto/sha1-ce-glue.c:39:11: warning: symbol 'sha1_ce_offsetof_finalize' was not declared. Should it be static?
> ../arch/arm64/crypto/sha2-ce-glue.c:38:11: warning: symbol 'sha256_ce_offsetof_count' was not declared. Should it be static?
> ../arch/arm64/crypto/sha2-ce-glue.c:40:11: warning: symbol 'sha256_ce_offsetof_finalize' was not declared. Should it be static?
>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>

>
> diff --git a/arch/arm64/crypto/sha1-ce-glue.c b/arch/arm64/crypto/sha1-ce-glue.c
> index 565ef604ca04..c63b99211db3 100644
> --- a/arch/arm64/crypto/sha1-ce-glue.c
> +++ b/arch/arm64/crypto/sha1-ce-glue.c
> @@ -25,6 +25,9 @@ struct sha1_ce_state {
>         u32                     finalize;
>  };
>
> +extern const u32 sha1_ce_offsetof_count;
> +extern const u32 sha1_ce_offsetof_finalize;
> +
>  asmlinkage void sha1_ce_transform(struct sha1_ce_state *sst, u8 const *src,
>                                   int blocks);
>
> diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c
> index 9450d19b9e6e..5e956d7582a5 100644
> --- a/arch/arm64/crypto/sha2-ce-glue.c
> +++ b/arch/arm64/crypto/sha2-ce-glue.c
> @@ -25,6 +25,9 @@ struct sha256_ce_state {
>         u32                     finalize;
>  };
>
> +extern const u32 sha256_ce_offsetof_count;
> +extern const u32 sha256_ce_offsetof_finalize;
> +
>  asmlinkage void sha2_ce_transform(struct sha256_ce_state *sst, u8 const *src,
>                                   int blocks);
>
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux