On Mon, Aug 24, 2020 at 4:13 PM Fabio Estevam <festevam@xxxxxxxxx> wrote: > > Building ARM allmodconfig leads to the following warnings: > > arch/arm/crypto/curve25519-glue.c:73:12: error: implicit declaration of function 'sg_copy_to_buffer' [-Werror=implicit-function-declaration] > arch/arm/crypto/curve25519-glue.c:74:9: error: implicit declaration of function 'sg_nents_for_len' [-Werror=implicit-function-declaration] > arch/arm/crypto/curve25519-glue.c:88:11: error: implicit declaration of function 'sg_copy_from_buffer' [-Werror=implicit-function-declaration] > > Include <linux/scatterlist.h> to fix such warnings This patch seems correct to me -- sg_copy_to_buffer, sg_nents_for_len. I wonder what header dependency chain caused us to miss this before. Either way, Acked-by: Jason A. Donenfeld <Jason@xxxxxxxxx>