Re: [v3 PATCH] crypto: caam - Move debugfs fops into standalone file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 06, 2020 at 09:09:49PM +0300, Horia Geantă wrote:
>
> Currently the debugfs fops are defined in caam/intern.h.  This causes
> problems because it creates identical static functions and variables
> in multiple files.  It also creates warnings when those files don't
> use the fops.
> 
> This patch moves them into a standalone file, debugfs.c.
> 
> It also removes unnecessary uses of ifdefs on CONFIG_DEBUG_FS.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> [Moved most of debugfs-related operations into debugfs.c.]
> Signed-off-by: Horia Geantă <horia.geanta@xxxxxxx>
> ---
>  drivers/crypto/caam/Makefile  |  2 +
>  drivers/crypto/caam/ctrl.c    | 77 +++------------------------
>  drivers/crypto/caam/debugfs.c | 96 +++++++++++++++++++++++++++++++++++
>  drivers/crypto/caam/debugfs.h | 26 ++++++++++
>  drivers/crypto/caam/intern.h  | 17 ------
>  drivers/crypto/caam/qi.c      | 20 ++------
>  6 files changed, 137 insertions(+), 102 deletions(-)
>  create mode 100644 drivers/crypto/caam/debugfs.c
>  create mode 100644 drivers/crypto/caam/debugfs.h

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux