On Tue, Aug 11, 2020 at 05:30:41PM +0300, Horia Geantă wrote: > > > + if (IS_ERR(fallback)) { > > + pr_err("Failed to allocate %s fallback: %ld\n", > > + tfm_name, PTR_ERR(fallback)); > > + return PTR_ERR(fallback); > Shouldn't error out so early. It might be that the fallback won't be needed. > Let's postpone this until we're sure fallback is required. Why? The generic should always be there as otherwise you won't even pass the self-test. If we're OOM then we should error out ASAP. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt