On Fri, Aug 07, 2020 at 07:39:19PM +0530, Srujana Challa wrote: > > +/* > + * On OcteonTX2 platform the parameter insts_num is used as a count of > + * instructions to be enqueued. The valid values for insts_num are: > + * 1 - 1 CPT instruction will be enqueued during LMTST operation > + * 2 - 2 CPT instructions will be enqueued during LMTST operation > + */ > +static inline void otx2_cpt_send_cmd(union otx2_cpt_inst_s *cptinst, > + u32 insts_num, void *obj) > +{ > + struct otx2_cptlf_info *lf = obj; > + void *lmtline = lf->lmtline; > + long ret; > + > + /* > + * Make sure memory areas pointed in CPT_INST_S > + * are flushed before the instruction is sent to CPT > + */ > + smp_wmb(); Why should this be a NOOP on UP? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt