On 8/6/2020 9:24 PM, Randy Dunlap wrote:
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> sa2ul.c uses sha{1,256,512}_zero_message_hash, so select the Kconfig symbols that provide those, like other crypto drivers do. Fixes this build error: ld: drivers/crypto/sa2ul.o: in function `sa_sha_digest': sa2ul.c:(.text+0x2b25): undefined reference to `sha512_zero_message_hash'
Thanks for catching this. Reviewed-by: Keerthy <j-keerthy@xxxxxx>
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # 2020-07-29 Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> Cc: linux-crypto@xxxxxxxxxxxxxxx Cc: Tero Kristo <t-kristo@xxxxxx> Cc: Keerthy <j-keerthy@xxxxxx> --- drivers/crypto/Kconfig | 3 +++ 1 file changed, 3 insertions(+) --- linux-next-20200806.orig/drivers/crypto/Kconfig +++ linux-next-20200806/drivers/crypto/Kconfig @@ -873,6 +873,9 @@ config CRYPTO_DEV_SA2UL select CRYPTO_AES select CRYPTO_AES_ARM64 select CRYPTO_ALGAPI + select CRYPTO_SHA1 + select CRYPTO_SHA256 + select CRYPTO_SHA512 select HW_RANDOM select SG_SPLIT help