On Mon, Aug 03, 2020 at 03:48:02PM +0100, Elena Petrova wrote: > > sendmsg is used for "Additional Data" input, and unlike entropy, it > could be useful outside of testing. But if you confirm it's not > useful, then yes, I can decouple the testing parts. Unless there is someone asking for it then I'd rather not export it to user-space. > Depends on the comment above, but otherwise, my only concern is that > the testing variant of rng_recvmsg would be largely copy-pasted from > the normal rng_recvmsg, apart from a few lines of lock/release and > crypto_rng_generate/crypto_rng_get_bytes. They could certainly share code through the use of functions. Chers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
