On Fri, Jul 31, 2020 at 04:15:41PM +0800, shenyang (M) wrote: > > Here if the user alloc a tfm of the algorithm the driver registers, > the function 'hisi_qm_wait_task_finish' which be added in patch 10 will > stop to remove the driver until the tfm is freed. 1. You don't introduce a bug in patch 8 only to fix it in patch 10. Lay the groundwork first before you rely on it. 2. You need to explain how the wait fixes the problem of unregistering an algorithm under a live tfm. Can you even do a wait at all in the face of a PCI unbind? What happens when the device reappears? Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
