Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Overly-generic names can cause problems like naming collisions, > confusing crash reports, and reduced grep-ability. E.g. see > commit d099ea6e6fde ("crypto - Avoid free() namespace collision"). > > Clean this up for the xts template by prefixing the names with "xts_". > > (I didn't use "crypto_xts_" instead because that seems overkill.) > > Also constify the tfm context in a couple places, and make > xts_free_instance() use the instance context structure so that it > doesn't just assume the crypto_skcipher_spawn is at the beginning. > > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > crypto/xts.c | 137 +++++++++++++++++++++++++++------------------------ > 1 file changed, 72 insertions(+), 65 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt