Re: [PATCH 1/1] inside-secure irq balance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sven Auhagen <sven.auhagen@xxxxxxxxxxxx> wrote:
>
> +       // Set affinity
> +       cpu = ring_id % num_online_cpus();
> +       irq_set_affinity_hint(irq, get_cpu_mask(cpu));
> +

This doesn't look right.  There is no guarantee that the online
CPUs are the lowest bits in the bitmask.  Also, what are you going
to do when the CPUs go down (or up)?

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux