On 7/9/2020 3:47 AM, Herbert Xu wrote: > On Wed, Jul 08, 2020 at 07:24:08PM +0300, Horia Geantă wrote: >> >> I think the commit message should be updated to reflect this logic: >> indeed, caam's implementation of ecb(arc4) is broken, >> but instead of fixing it, crypto API-based ecb(arc4) >> is removed completely from the kernel (hence from caam driver) >> due to skcipher limitations in terms of handling the keystream. > > Actually that's not quite true. The reason I create this patch > in the first place is to remove this limitation from skcipher. > But the reason / context has changed in the meantime right? If skcipher limitation is eliminated, will it be possible to add ecb(arc4) implementation back in caam, this time with the state stored in the request object? My understanding is: no, if Ard's arc4 RFC series is merged. Thanks, Horia
