On Wed, Jul 01, 2020 at 03:19:54PM +0800, Yang Shen wrote: > When the devices are removed or not existing, the corresponding algorithms > which are registered by 'hisi-zip' driver can't be used. > > Move 'hisi_zip_register_to_crypto' from 'hisi_zip_init' to > 'hisi_zip_probe'. The algorithms will be registered to crypto only when > there is device bind on the driver. And when the devices are removed, > the algorithms will be unregistered. You can't just unregister a live algorithm because if someone holds a reference count on it then the Crypto API will crash. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
