On Mon, 6 Jul 2020, Eric Biggers wrote: > On Wed, Jul 01, 2020 at 03:59:10AM -0400, Mikulas Patocka wrote: > > Thanks for cleaning this up. > > > > Mikulas > > Do you have any real comments on this? > > Are the usage restrictions okay for dm-crypt? > > - Eric I think that your patch series is OK. dm-crypt submits crypto requests with size aligned on 512 bytes. The start of the crypto request is usually aligned on 512 bytes, but not always - XFS with SLUB_DEBUG will send bios with misaligned bv_offset (but the bio vectors don't cross a page). Mikulas