> -----Original Message----- > From: Herbert Xu [mailto:herbert@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, July 3, 2020 4:11 PM > To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; Wangzhou (B) <wangzhou1@xxxxxxxxxxxxx>; > Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>; > akpm@xxxxxxxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; > linux-mm@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Linuxarm > <linuxarm@xxxxxxxxxx>; Seth Jennings <sjenning@xxxxxxxxxx>; Dan > Streetman <ddstreet@xxxxxxxx>; Vitaly Wool <vitaly.wool@xxxxxxxxxxxx> > Subject: Re: [PATCH v2 1/3] crypto: permit users to specify numa node of > acomp hardware > > On Tue, Jun 23, 2020 at 04:16:08PM +1200, Barry Song wrote: > > > > -void *crypto_create_tfm(struct crypto_alg *alg, > > - const struct crypto_type *frontend) > > +void *crypto_create_tfm_node(struct crypto_alg *alg, > > + const struct crypto_type *frontend, > > + int node) > > { > > char *mem; > > struct crypto_tfm *tfm = NULL; > > @@ -451,6 +452,7 @@ void *crypto_create_tfm(struct crypto_alg *alg, > > > > tfm = (struct crypto_tfm *)(mem + tfmsize); > > tfm->__crt_alg = alg; > > + tfm->node = node; > > Should the kzalloc also use node? Yes, it would be nice since the tfm will mainly be accessed by CPU on the specific node. > > Thanks, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt Thanks Barry
