The RC4 algorithm does not fit the sckipher model very well: it is a stream cipher that combines the key and IV into a single vector, which implies that using the same key more than once amounts to stream cipher IV reuse, and therefore catastrophic failure. So let's replace the remaining legacy users (WEP and TKIP in the staging tree) to the ARC4 library interface, which does not rely on the crypto API at all. Also, remove the obsolete RC4-HMAC-MD5 algorithm from the SUNRPC driver stack. NOTE: It should not be too difficult to switch the kerberos code over to the ARC4 library interface as well, given that much of it uses a different code path already. But we should only do so if we really need to keep this support around, and it seems that this was only ever intended as a transitional algorithm for Windows NT/2000 clients. That leaves no remaining users of the ecb(arc4) skcipher, so we can remove any implementations as well. Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Cc: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> Cc: Anna Schumaker <anna.schumaker@xxxxxxxxxx> Cc: "J. Bruce Fields" <bfields@xxxxxxxxxxxx> Cc: Chuck Lever <chuck.lever@xxxxxxxxxx> Cc: Eric Biggers <ebiggers@xxxxxxxxxx> Cc: linux-crypto@xxxxxxxxxxxxxxx Cc: netdev@xxxxxxxxxxxxxxx Cc: devel@xxxxxxxxxxxxxxxxxxxx Cc: linux-nfs@xxxxxxxxxxxxxxx Ard Biesheuvel (7): staging/rtl8192e: switch to RC4 library interface staging/rtl8192u: switch to RC4 library interface SUNRPC: remove RC4-HMAC-MD5 support from KerberosV crypto: remove ARC4 support from the skcipher API crypto: n2 - remove ecb(arc4) support crypto: bcm-iproc - remove ecb(arc4) support crypto: tcrypt - remove ecb(arc4) testing/benchmarking support crypto/Kconfig | 12 - crypto/Makefile | 1 - crypto/arc4.c | 76 ----- crypto/tcrypt.c | 21 +- crypto/testmgr.c | 7 - crypto/testmgr.h | 62 ---- drivers/crypto/bcm/cipher.c | 96 +----- drivers/crypto/bcm/cipher.h | 1 - drivers/crypto/bcm/spu.c | 23 +- drivers/crypto/bcm/spu.h | 1 - drivers/crypto/bcm/spu2.c | 12 +- drivers/crypto/bcm/spu2.h | 1 - drivers/crypto/n2_core.c | 46 --- drivers/net/wireless/intel/ipw2x00/Kconfig | 1 - drivers/net/wireless/intersil/hostap/Kconfig | 1 - drivers/staging/rtl8192e/Kconfig | 4 +- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 70 +---- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 72 +---- drivers/staging/rtl8192u/Kconfig | 1 + .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 82 +----- .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 64 +--- include/linux/sunrpc/gss_krb5.h | 11 - include/linux/sunrpc/gss_krb5_enctypes.h | 9 +- net/sunrpc/Kconfig | 1 - net/sunrpc/auth_gss/gss_krb5_crypto.c | 276 ------------------ net/sunrpc/auth_gss/gss_krb5_mech.c | 95 ------ net/sunrpc/auth_gss/gss_krb5_seal.c | 1 - net/sunrpc/auth_gss/gss_krb5_seqnum.c | 87 ------ net/sunrpc/auth_gss/gss_krb5_unseal.c | 1 - net/sunrpc/auth_gss/gss_krb5_wrap.c | 65 +---- 30 files changed, 78 insertions(+), 1122 deletions(-) delete mode 100644 crypto/arc4.c -- 2.17.1
