On Tue, Jun 30, 2020 at 02:15:55PM -0400, Mikulas Patocka wrote: > > Index: linux-2.6/crypto/pcrypt.c > =================================================================== > --- linux-2.6.orig/crypto/pcrypt.c 2020-06-29 16:03:07.346417000 +0200 > +++ linux-2.6/crypto/pcrypt.c 2020-06-30 20:11:56.636417000 +0200 > @@ -225,19 +225,21 @@ static int pcrypt_init_instance(struct c > return 0; > } > > -static int pcrypt_create_aead(struct crypto_template *tmpl, struct rtattr **tb, > - u32 type, u32 mask) > +static int pcrypt_create_aead(struct crypto_template *tmpl, struct rtattr **tb) > { Rather than removing these two arguments, I think you should pass along algt instead. > struct pcrypt_instance_ctx *ctx; > struct crypto_attr_type *algt; > struct aead_instance *inst; > struct aead_alg *alg; > + u32 mask; > int err; > > algt = crypto_get_attr_type(tb); > if (IS_ERR(algt)) > return PTR_ERR(algt); Then we could remove this bit. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt