>>>>> Fix this by … >>>> >>>> Please replace the beginning of this sentence with the tag “Fixes”. >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n183 >>> >>> No, not really. The comment you (partially) quoted explains how the >>> issue is fixed, your suggestion explains what commit introduced the fix >>> in the first place. They are both beneficial, but there's strictly no >>> reason to remove the former for the latter. >> >> Do you care to improve this change description another bit? > > I'm not sure which change description you're talking about? Repetition: https://lore.kernel.org/patchwork/patch/1260551/ https://lore.kernel.org/linux-crypto/20200622024014.11347-1-dinghao.liu@xxxxxxxxxx/ pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a corresponding decrement is needed on the error handling path to keep the counter balanced. Fix this by adding the missed function call. How do you think about to avoid a wording weakness there (for example) besides other possible adjustments? Regards, Markus
