On Fri, 5 Jun 2020 16:01:18 +0000 Pooja Trivedi wrote: > This selftest tests for cases where sendfile's 'count' > parameter is provided with a size greater than the intended > file size. > > Motivation: When sendfile is provided with 'count' parameter > value that is greater than the size of the file, kTLS example > fails to send the file correctly. Last chunk of the file is > not sent, and the data integrity is compromised. > The reason is that the last chunk has MSG_MORE flag set > because of which it gets added to pending records, but is > not pushed. > Note that if user space were to send SSL_shutdown control > message, pending records would get flushed and the issue > would not happen. So a shutdown control message following > sendfile can mask the issue. > > Signed-off-by: Pooja Trivedi <pooja.trivedi@xxxxxxxxxxxxx> > Signed-off-by: Mallesham Jatharkonda <mallesham.jatharkonda@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Josh Tway <josh.tway@xxxxxxxxxxxxx> Looks good to me, but I'm not 100% sure we want to merge it before the fix is merged. Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx> Thanks!
