On Fri, Jun 05, 2020 at 05:34:32PM +0800, Zhangfei Gao wrote: > Will add a check after the copy. > > strlcpy(interface.name, pdev->driver->name, sizeof(interface.name)); > if (strlen(pdev->driver->name) != strlen(interface.name)) > return -EINVAL; You don't need to do strlen. The function strlcpy returns the length of the source string. Better yet use strscpy which will even return an error for you. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
