Re: [PATCH 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> … So the system will crash
> at last when this memory be used again.

I would prefer a wording with less typos here.


> We can free the resources before calling ->complete to fix this issue.

* An imperative wording can be nicer.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151

* You proposed to move a call of the function “crypto_finalize_skcipher_request”.
  How does this change fit to the mentioned position?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux