On Fri, May 01, 2020 at 11:34:23PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > The return value of xxh64_update() is pointless and confusing, since an > error is only returned for input==NULL. But the callers must ignore > this error because they might pass input=NULL, length=0. > > Likewise for xxh32_update(). > > Just make these functions return void. > > Cc: Nikolay Borisov <nborisov@xxxxxxxx> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx> > --- > > lib/xxhash.c doesn't actually have a maintainer, but probably it makes > sense to take this through the crypto tree, alongside the other patch I > sent to return void in lib/crypto/sha256.c. Herbert, are you planning to apply this patch? - Eric
