Re: [PATCH] Crypto/chcr: drop refcount on error path in chcr_aead_op()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 5/12/2020 2:07 PM, Dan Carpenter wrote:
We need to drop inflight counter before returning on this error path.

Fixes: d91a3159e8d9 ("Crypto/chcr: fix gcm-aes and rfc4106-gcm failed tests")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
  drivers/crypto/chelsio/chcr_algo.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c
index 83ddc2b39490e..e05998a1c0148 100644
--- a/drivers/crypto/chelsio/chcr_algo.c
+++ b/drivers/crypto/chelsio/chcr_algo.c
@@ -3744,6 +3744,7 @@ static int chcr_aead_op(struct aead_request *req,
  	    crypto_ipsec_check_assoclen(req->assoclen) != 0) {
  		pr_err("RFC4106: Invalid value of assoclen %d\n",
  		       req->assoclen);
+		chcr_dec_wrcount(cdev);
  		return -EINVAL;
  	}


Looks good. Thanks a lot.




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux