On Mon, 27 Apr 2020 at 09:23, Hadar Gat <Hadar.Gat@xxxxxxx> wrote: > > > > -----Original Message----- > > From: Ard Biesheuvel <ardb@xxxxxxxxxx> > > > > On Mon, 27 Apr 2020 at 07:42, Hadar Gat <hadar.gat@xxxxxxx> wrote: > > > > > > The cctrng is unusable on non-DT systems so we should depend on it. > > > > > > Signed-off-by: Hadar Gat <hadar.gat@xxxxxxx> > > > --- > > > drivers/char/hw_random/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/char/hw_random/Kconfig > > > b/drivers/char/hw_random/Kconfig index 0c99735..df2d001 100644 > > > --- a/drivers/char/hw_random/Kconfig > > > +++ b/drivers/char/hw_random/Kconfig > > > @@ -476,7 +476,7 @@ config HW_RANDOM_KEYSTONE > > > > > > config HW_RANDOM_CCTRNG > > > tristate "Arm CryptoCell True Random Number Generator support" > > > - depends on HAS_IOMEM > > > + depends on HAS_IOMEM & OF > > > > Does your driver in fact depend on CONFIG_HAS_IOMEM ? > > Yes, it uses devm_ioremap_resource() for registers mapping. > Fair enough
