On Thu, 23 Apr 2020 at 09:40, Christophe Leroy <christophe.leroy@xxxxxx> wrote: > > > > Le 23/04/2020 à 09:18, Ard Biesheuvel a écrit : > > FYI: you shouldn't cc stable@xxxxxxxxxxxxxxx directly on your patches, > > or add the cc: line. Only patches that are already in Linus' tree > > should be sent there. > > > > Also, the fixes tags are really quite sufficient. In fact, it is > > actually rather difficult these days to prevent something from being > > taken into -stable if the bots notice that it applies cleanly. > > According to Kernel Documentation, > https://www.kernel.org/doc/html/latest/process/submitting-patches.html : > > > Patches that fix a severe bug in a released kernel should be directed > toward the stable maintainers by putting a line like this: > > Cc: stable@xxxxxxxxxxxxxxx > > into the sign-off area of your patch (note, NOT an email recipient). You > should also read Documentation/process/stable-kernel-rules.rst in > addition to this file. > > > Isn't it correct anymore ? > So this states clearly that you should not actually cc the patch to stable@xxxxxxxxxxxxxxx, you should only add the cc: line to the commit log area if it fixes a *severe* bug. Once the patch makes it into Linus' tree, the cc: line will be used by the -stable maintainers to locate the patch and pull it in. But as I pointed out, even with just the fixes: tags, the patch will be picked up by -stable anyway. Omitting the cc: line helps prevent inadvertently sending the patch to stable@xxxxxxxxxxxxxxx directly, since git send-email typically honours Cc: lines in its input in its default configuration.
